Deprecate unsafe default options of JSON.load
#644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
deprecate-unsafe-load
branch
from
c50c9cd
to
798d0f5
Compare
casperisfine
force-pushed
the
deprecate-unsafe-load
branch
3 times, most recently
from
6e91648
to
7719466
Compare
[Feature #19528] Ref: https://bugs.ruby-lang.org/issues/19528 `load` is understood as the default method for serializer kind of libraries, and the default options of `JSON.load` has caused many security vulnerabilities over the years. The plan is to do like YAML/Psych, deprecate these default options and direct users toward using `JSON.unsafe_load` so at least it's obvious it should be used against untrusted data.
casperisfine
force-pushed
the
deprecate-unsafe-load
branch
from
7719466
to
72b92cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/19528
loadis understood as the default method for serializer kind of libraries, and the default options ofJSON.loadhas caused many security vulnerabilities over the years.The plan is to do like YAML/Psych, deprecate these default options and direct users toward using
JSON.unsafe_loadso at least it's obvious it shouldn't be used against untrusted data.